----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19657/#review38562 -----------------------------------------------------------
src/master/registrar.cpp <https://reviews.apache.org/r/19657/#comment70826> These are not alphabetical. src/master/registrar.cpp <https://reviews.apache.org/r/19657/#comment70825> Why is this not at the same place as Request and Response below? src/master/registrar.cpp <https://reviews.apache.org/r/19657/#comment70823> const? Also, why make it a method instead of just string like we did in master::http and slave::http? const static string REGISTRY_HELP; const string RegistrarProcess::REGISTRY_HELP = HELP(); src/master/registrar.cpp <https://reviews.apache.org/r/19657/#comment70822> Can you show an example in the description like we did for monitor? - Vinod Kone On March 26, 2014, 12:22 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19657/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 12:22 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > Added an endpoint for retrieving the registry contents. > > > Diffs > ----- > > src/master/registrar.cpp ba39ad4a92aff97cb74c00f3a865ce670f22c29a > > Diff: https://reviews.apache.org/r/19657/diff/ > > > Testing > ------- > > make check and hit the endpoint before a slave registered, after a slave > registered, after a slave was removed. > > > Thanks, > > Ben Mahler > >
