-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19657/#review38647
-----------------------------------------------------------

Ship it!



src/master/registrar.cpp
<https://reviews.apache.org/r/19657/#comment70908>

    should come after process::terminate.



src/master/registrar.cpp
<https://reviews.apache.org/r/19657/#comment70911>

    Not sure what this order is :)
    
    >>> sorted(["Failure", "Future", "DESCRIPTION", "HELP", "Owned", "Process", 
"Promise", "TLDR", "USAGE"])
    ['DESCRIPTION', 'Failure', 'Future', 'HELP', 'Owned', 'Process', 'Promise', 
'TLDR', 'USAGE']
    


- Vinod Kone


On March 26, 2014, 1:34 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19657/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 1:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-764
>     https://issues.apache.org/jira/browse/MESOS-764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added an endpoint for retrieving the registry contents.
> 
> 
> Diffs
> -----
> 
>   src/master/registrar.cpp ba39ad4a92aff97cb74c00f3a865ce670f22c29a 
> 
> Diff: https://reviews.apache.org/r/19657/diff/
> 
> 
> Testing
> -------
> 
> make check and hit the endpoint before a slave registered, after a slave 
> registered, after a slave was removed.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to