----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19852/#review39090 -----------------------------------------------------------
Ship it! Thanks Jie! src/log/coordinator.cpp <https://reviews.apache.org/r/19852/#comment71479> ... that were just implicitly promised ... Also, can we add something like the following (since it's not in the JIRA issue): This is safe because log::catchup would increment the proposal number automatically after failing to fill implicitly promised positions and this just shortcuts that process. - Benjamin Hindman On March 31, 2014, 5:10 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19852/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 5:10 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1165 > https://issues.apache.org/jira/browse/MESOS-1165 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-1165 for details. > > Also added a test for capturing regression. > > > Diffs > ----- > > src/log/coordinator.cpp caa4b85 > src/tests/log_tests.cpp b368cde > > Diff: https://reviews.apache.org/r/19852/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
