> On March 31, 2014, 10:12 p.m., Jiang Yan Xu wrote: > > src/log/coordinator.cpp, line 235 > > <https://reviews.apache.org/r/19852/diff/1/?file=542427#file542427line235> > > > > No biggie, just not sure if it's abundantly clear from the code or > > comments elsewhere that we don't need to update > > CoordiantorProcess::proposal because we are catching up "previous" > > positions thus won't mess up with the implicit promises for future > > positions.
Updated the comments. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19852/#review39112 ----------------------------------------------------------- On March 31, 2014, 5:10 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19852/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 5:10 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1165 > https://issues.apache.org/jira/browse/MESOS-1165 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-1165 for details. > > Also added a test for capturing regression. > > > Diffs > ----- > > src/log/coordinator.cpp caa4b85 > src/tests/log_tests.cpp b368cde > > Diff: https://reviews.apache.org/r/19852/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
