----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19764/#review39177 -----------------------------------------------------------
src/state/protobuf.hpp <https://reviews.apache.org/r/19764/#comment71538> Have you confirmed that the callers of this method are safe with this change? src/state/state.hpp <https://reviews.apache.org/r/19764/#comment71539> ditto. - Vinod Kone On April 1, 2014, 1:13 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19764/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 1:13 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1155 > https://issues.apache.org/jira/browse/MESOS-1155 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/state/protobuf.hpp 802617b48586d8fc682d5efda3e2b86205e988b6 > src/state/state.hpp bebfe02dcdcbaec8742d173e2233817288722bd8 > > Diff: https://reviews.apache.org/r/19764/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” > –gtest_also_run_disabled_tests > On my test machine it costs about 40-60ms to copy a registry of 20,000 slaves. > > > Thanks, > > Jiang Yan Xu > >
