> On April 1, 2014, 10:55 a.m., Vinod Kone wrote: > > > > Jiang Yan Xu wrote: > yeah, ran make check. > > Ben Mahler wrote: > A visual check would be necessary here for all users of these methods, as > the errors that this may introduce are run-time errors which may not > necessarily be exercised during the tests.
Yeah, visual check as well. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19764/#review39177 ----------------------------------------------------------- On April 14, 2014, 11:56 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19764/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 11:56 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1155 > https://issues.apache.org/jira/browse/MESOS-1155 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/state/protobuf.hpp 802617b48586d8fc682d5efda3e2b86205e988b6 > src/state/state.hpp 2c0bb20b33bb8e71689a8ca5a648bffc32d5eece > > Diff: https://reviews.apache.org/r/19764/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” > –gtest_also_run_disabled_tests > On my test machine it costs about 40-60ms to copy a registry of 20,000 slaves > and 95ms for 50,000 slaves. > > > Thanks, > > Jiang Yan Xu > >
