----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19877/#review39213 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/19877/#comment71576> Can you add a CHECK here to make sure this expectation is valid? - Vinod Kone On April 1, 2014, 6:27 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19877/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 6:27 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Split from and is now blocking https://reviews.apache.org/r/19795/. > This patch removes an obsolete piece of code in the slave which sets the > framework id in the executor info. > It has already been marked for deletion and significantly simplifies the new > reliable reregistration code. > > > Diffs > ----- > > src/slave/slave.cpp 6d901dc > > Diff: https://reviews.apache.org/r/19877/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
