> On April 1, 2014, 4:17 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 682 > > <https://reviews.apache.org/r/19877/diff/1/?file=543971#file543971line682> > > > > Can you add a CHECK here to make sure this expectation is valid?
You bet - thanks! - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19877/#review39213 ----------------------------------------------------------- On April 1, 2014, 11:27 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19877/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 11:27 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Split from and is now blocking https://reviews.apache.org/r/19795/. > This patch removes an obsolete piece of code in the slave which sets the > framework id in the executor info. > It has already been marked for deletion and significantly simplifies the new > reliable reregistration code. > > > Diffs > ----- > > src/slave/slave.cpp 6d901dc > > Diff: https://reviews.apache.org/r/19877/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
