----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19965/#review39376 -----------------------------------------------------------
Patch looks great! Reviews applied: [19775, 19965] All tests passed. - Mesos ReviewBot On April 2, 2014, 11:26 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19965/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 11:26 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1181 > https://issues.apache.org/jira/browse/MESOS-1181 > > > Repository: mesos-git > > > Description > ------- > > Enabled whitespace/semicolon rule for cpplint, which covers the following > logic: > # You should always have a space after a semicolon > # except for few corner cases > > # You shouldn't have a space before a semicolon at the end of the line. > # There's a special case for "for" since the style guide allows space before > # the semicolon there. > > Also cleaning up a mesos-style.py comment, and enabling build/include_alpha, > which seems to pass for me. > > > Diffs > ----- > > src/tests/cgroups_tests.cpp 6ba9de6 > support/mesos-style.py edd41f926d6df30513f8fa6c928960e6495af70a > > Diff: https://reviews.apache.org/r/19965/diff/ > > > Testing > ------- > > Ran mesos-style.py over entire source base with whitespace/semicolon enabled. > > > Thanks, > > Adam B > >
