> On April 3, 2014, 6:46 a.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, line 100 > > <https://reviews.apache.org/r/19991/diff/2/?file=547564#file547564line100> > > > > Why do we need ignorePartial?
Because it's possible that we're reading from a file that has incomplete information because the writer didn't write all it's data (for example, because it crashed). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39405 ----------------------------------------------------------- On April 3, 2014, 6:35 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19991/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 6:35 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The only user of os::read(fd, size) that required the seek semantics was > protobuf::read, and it could easily be modified to do the unseeking itself. > Thus, I've cleaned this up so os::read(fd, size) can be used on things like > pipes and sockets! > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d6a124e0515b2de7b886d1f5837eedb497b2eb8b > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 939cb7238fe2210046b69573ebd2f3b5de918920 > > Diff: https://reviews.apache.org/r/19991/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
