----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19991/#review39419 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp <https://reviews.apache.org/r/19991/#comment71811> we could clean up all these delete[] calls if we had a scoped_array type that autodeleted the buffer on scope exit. I'm happy to add it to stout if you want. 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp <https://reviews.apache.org/r/19991/#comment71810> sp: avaiable -> available - Dominic Hamon On April 2, 2014, 11:35 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19991/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 11:35 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The only user of os::read(fd, size) that required the seek semantics was > protobuf::read, and it could easily be modified to do the unseeking itself. > Thus, I've cleaned this up so os::read(fd, size) can be used on things like > pipes and sockets! > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d6a124e0515b2de7b886d1f5837eedb497b2eb8b > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 939cb7238fe2210046b69573ebd2f3b5de918920 > > Diff: https://reviews.apache.org/r/19991/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
