----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19966/#review39415 -----------------------------------------------------------
Patch looks great! Reviews applied: [19775, 19966] All tests passed. - Mesos ReviewBot On April 3, 2014, 6:50 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19966/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 6:50 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1181 > https://issues.apache.org/jira/browse/MESOS-1181 > > > Repository: mesos-git > > > Description > ------- > > Enabled whitespace/blank_line rule for cpplint, which covers the following: > 'Redundant blank line at the start of a code block ' > 'should be deleted.' > 'Redundant blank line at the end of a code block ' > 'should be deleted.' > 'Do not leave a blank line after "public|protected|private:"' > '"class|struct:" should be preceded by a blank line' > > > Diffs > ----- > > src/common/resources.cpp 61c5bda > src/slave/slave.cpp a356f5f > src/tests/cluster.hpp 11684d9 > src/tests/mesos.hpp f77fbfe > support/mesos-style.py edd41f926d6df30513f8fa6c928960e6495af70a > > Diff: https://reviews.apache.org/r/19966/diff/ > > > Testing > ------- > > Ran mesos-style.py over entire source base with whitespace/blank_line enabled. > > > Thanks, > > Adam B > >
