----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/#review39746 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/20080/#comment72360> Eventually this will need lots more documentation, here or someplace else but here is a good source of truth. In the mean time, how about a caveat that not all containerizers currently implement ContainerInfo so it's possible that you'll launch a task with a container but it will fail. Also, can we give at least some explanation of 'image' and 'options'? Must 'image' be a URI? Etc. - Benjamin Hindman On April 7, 2014, 1:19 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20080/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 1:19 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Introduces the ContainerInfo protobuf as part of CommandInfo. > Right now, if present, the mesos containerizer fails the task launch to point > out that we do not support it on that containerizer. > > This will be needed for the ExternalContainerizer and possibly other > containerizers as well. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7f > src/slave/containerizer/mesos_containerizer.cpp c819c97 > > Diff: https://reviews.apache.org/r/20080/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
