> On April 7, 2014, 2:50 p.m., Niklas Nielsen wrote: > > Is this RR really dependent on r19795, r18403? It seems to me that we could > > land this independently (while the others are in flight). > > Benjamin Hindman wrote: > I agree that this does not depend on 19795 or 18403, so let's remove > those and commit this independently.
Those two implement TaskInfo as a parameter within the Containerizer context. Without TaskInfo, we dont have a CommandInfo in that scope. If I did not have a CommandInfo all the way down within the Containerizer, I could not fail launching that task depending on if the Containerizer supports ContainerInfo or not. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20080/#review39674 ----------------------------------------------------------- On April 7, 2014, 1:19 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20080/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 1:19 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Introduces the ContainerInfo protobuf as part of CommandInfo. > Right now, if present, the mesos containerizer fails the task launch to point > out that we do not support it on that containerizer. > > This will be needed for the ExternalContainerizer and possibly other > containerizers as well. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7f > src/slave/containerizer/mesos_containerizer.cpp c819c97 > > Diff: https://reviews.apache.org/r/20080/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
