> On April 2, 2014, 5:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 2299 > > <https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line2299> > > > > Why is this returning a Future? Is this for future proofing (no pun > > intended).
This is the future that executor->info is set to in Framework::launch(), but I'll move it to the dependent review. > On April 2, 2014, 5:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 992 > > <https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line992> > > > > Do we need this future passed through considering we have the > > executorInfo member variable? > > Niklas Nielsen wrote: > I think it was mostly for error checking. Should we move towards > .onReady() and have .onFailed(), onDiscarded() or a onAny(error(lambda::_1)) > which catches and reports those errors? Per our discussion, let's do this in a subsequent review for the slave.cpp > On April 2, 2014, 5:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3316 > > <https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line3316> > > > > why the change to .then? Think it is a left-over from when executorLaunched returned a future to the executor struct - apologize. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/#review39335 ----------------------------------------------------------- On April 7, 2014, 4:53 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19795/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 4:53 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This is the 2nd part of the task-info patch split > (https://reviews.apache.org/r/18403/) and changes Executor::info to an > executor info future. > This is motivated by delegating executor info creation/choice to the > containerizer to address new container/executor scenarios > (https://issues.apache.org/jira/browse/MESOS-922). > > This patch use the new Executor::info and introduces new continuations to > deal with launching containers i.e. executor infos are to be determined. > > > Diffs > ----- > > src/slave/http.cpp 594032d > src/slave/slave.hpp 15e23ce > src/slave/slave.cpp a356f5f > > Diff: https://reviews.apache.org/r/19795/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
