> On April 2, 2014, 5:47 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 3260-3264 > > <https://reviews.apache.org/r/19795/diff/3/?file=544927#file544927line3260> > > > > Do you want to address this TODO now? > > > > I'm afraid that if you only make ExecutorInfo a future when we revisit > > this TODO we have to go through the same pain of refactoring? > > Niklas Nielsen wrote: > So we should actually have a different Containerizer::launch() API. I > wonder if the whole executor struct or a nested struct should be returned by > launch (with directory, container id and executor info)?
This would complicate recovery/clean-up - do you remember what the motivation was for delegating container id to the containerizer? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19795/#review39335 ----------------------------------------------------------- On April 10, 2014, 11:11 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19795/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 11:11 a.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Bugs: MESOS-922 > https://issues.apache.org/jira/browse/MESOS-922 > > > Repository: mesos-git > > > Description > ------- > > This is the 2nd part of the task-info patch split > (https://reviews.apache.org/r/18403/) and changes Executor::info to an > executor info future. > This is motivated by delegating executor info creation/choice to the > containerizer to address new container/executor scenarios > (https://issues.apache.org/jira/browse/MESOS-922). > > This patch use the new Executor::info and introduces new continuations to > deal with launching containers i.e. executor infos are to be determined. > > > Diffs > ----- > > src/slave/http.cpp 594032d > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > src/tests/containerizer.cpp bfb9341 > > Diff: https://reviews.apache.org/r/19795/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
