----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/#review39808 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20127/#comment72437> Can we return Try<int> for descriptive (hard coded) error messages and remain async signal safe? If not, perhaps document this so someone else doesn't add it later :-) 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20127/#comment72440> standard system() just returns the exit status of the shell, whatever that may be. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/20127/#comment72438> what about testing the failure path in the child? EXPECT_EQ(-1, os::system("invalid.command.that.should.not.be.found")); - Ian Downes On April 8, 2014, 6:16 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20127/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 6:16 p.m.) > > > Review request for mesos, Ben Mahler and Ian Downes. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp db5ae69 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d61db30 > > Diff: https://reviews.apache.org/r/20127/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
