> On April 8, 2014, 6:36 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 574 > > <https://reviews.apache.org/r/20127/diff/1/?file=553118#file553118line574> > > > > standard system() just returns the exit status of the shell, whatever > > that may be. > > Jie Yu wrote: > Yeah, but the users of os::system needs to check WIFEXITED(status) and > WEXITSTATUS(status) then. I prefer not having users worry about that:) What > do you think?
Changed my mind. Return status now. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20127/#review39808 ----------------------------------------------------------- On April 9, 2014, 7:43 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20127/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 7:43 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp db5ae69 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d61db30 > > Diff: https://reviews.apache.org/r/20127/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
