----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/#review39922 -----------------------------------------------------------
If you haven't already, can you test this with both RB and GH review/PRs and add it to "testing done" section? support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72669> s/print_help_and_exit/usage/ ? support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72682> kill this. support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72670> Not yours but this should actually be AUTHOR and AUTHOR_EMAIL. s/REVIEWER/AUTHOR/ support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72672> kill the echo? support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72677> This is common for GH and RB. Why not pull this out? support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72671> We need to get the Author's name and email here. Does GitHub API provide this? support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72685> Also add the pull request url. e.g: This closes #13. Review: https://github.com/apache/mesos/pull/13 support/apply-review.sh <https://reviews.apache.org/r/20173/#comment72684> indentation. - Vinod Kone On April 9, 2014, 6:35 p.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20173/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 6:35 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1202 > https://issues.apache.org/jira/browse/MESOS-1202 > > > Repository: mesos-git > > > Description > ------- > > Updates support/apply-review.sh to work with both github and reviewboard. > > > Diffs > ----- > > support/apply-review.sh 8e2f916233423dcad81c1062c207575772138c32 > > Diff: https://reviews.apache.org/r/20173/diff/ > > > Testing > ------- > > > Thanks, > > Jake Farrell > >
