> On April 10, 2014, 4:21 a.m., Vinod Kone wrote: > > support/apply-review.sh, line 104 > > <https://reviews.apache.org/r/20173/diff/1-2/?file=553960#file553960line104> > > > > Hmm. Why not get this info via the API like we did with RB above? > > > > AFAICT, this should work (note: i didn't test this..just looked at the > > GH api) > > > > USER_URL=$(${JSONURL} ${API_URL} user url) > > > > AUTHOR_NAME=$(${JSONURL} ${USER_URL} name) > > AUTHOR_EMAIL=$(${JSONURL} ${USER_URL} email)
Email is not available for a user via the pull request api, https://developer.github.com/v3/pulls/#get-a-single-pull-request. Tested with ./support/jsonurl.py https://api.github.com/repos/apache/mesos/pulls/11 before switching to the git send-email to parse out the patch Cc: field to get the author - Jake ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20173/#review39980 ----------------------------------------------------------- On April 10, 2014, 4:39 a.m., Jake Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20173/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 4:39 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1202 > https://issues.apache.org/jira/browse/MESOS-1202 > > > Repository: mesos-git > > > Description > ------- > > Updates support/apply-review.sh to work with both github and reviewboard. > > > Diffs > ----- > > support/apply-review.sh 8e2f916 > > Diff: https://reviews.apache.org/r/20173/diff/ > > > Testing > ------- > > Tested against review 11099 and pull request 11 and printed out author and > message to be committed. > > > trunk $ ./support/apply-review.sh -r 11099 > --2014-04-09 23:21:21-- https://reviews.apache.org/r/11099/diff/raw/ > Resolving reviews.apache.org... 140.211.11.74 > Connecting to reviews.apache.org|140.211.11.74|:443... connected. > HTTP request sent, awaiting response... 200 OK > Length: 1388 (1.4K) [text/x-patch] > Saving to: ‘11099.patch’ > > 100%[============================================================================================================>] > 1,388 --.-K/s in 0s > > 2014-04-09 23:21:22 (27.0 MB/s) - ‘11099.patch’ saved [1388/1388] > > Author: Vinod Kone <[email protected]> > Added rename() to os.hpp. > > Discarding old review, because post-reviews is giving me issues with the > recent git repo changes. > > Old: https://reviews.apache.org/r/11056 > > > Review: https://reviews.apache.org/r/11099 > > > trunk $ ./support/apply-review.sh -g 11 > --2014-04-09 23:21:36-- https://github.com/apache/mesos/pull/11.patch > Resolving github.com... 192.30.252.129 > Connecting to github.com|192.30.252.129|:443... connected. > HTTP request sent, awaiting response... 200 OK > Length: 1287 (1.3K) [text/plain] > Saving to: ‘11.patch’ > > 100%[============================================================================================================>] > 1,287 --.-K/s in 0s > > 2014-04-09 23:21:36 (5.66 MB/s) - ‘11.patch’ saved [1287/1287] > > 11.patch:22: trailing whitespace. > Jenkins, Spark, Aurora, and other frameworks on a dynamically shared pool of > warning: 1 line adds whitespace errors. > > Author: Dave Lester <[email protected]> > Updates README project description. > > Updates README project description to be in sync with language used on the > Mesos website. > > This closes: #11 > Review: https://github.com/apache/mesos/pull/11 > > > Thanks, > > Jake Farrell > >
