----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20141/#review39926 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/20141/#comment72693> Do we want the containerizer proto in a separate python module? I don't know what is idiomatic in Python but can we just add containerizer protos to mesos_pb2? Similarly for Java. src/Makefile.am <https://reviews.apache.org/r/20141/#comment72691> this seems to be the same rule as above? src/slave/containerizer/containerizer.proto <https://reviews.apache.org/r/20141/#comment72688> What about protobufs for Usage, Wait and Destroy? Should Termination also be pulled into this namespace? - Vinod Kone On April 9, 2014, 12:25 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20141/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 12:25 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Adds containerizer.proto containing protobuf message definitions for "launch" > and "update". Both are used in the upcoming External Containerizer. > > These protos are defined within their own namespace: containerizer. > > > Diffs > ----- > > src/Makefile.am 95f133d > src/slave/containerizer/containerizer.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/20141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
