----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20141/#review40228 -----------------------------------------------------------
Looks good Till, just a little more code motion with the containerizer.proto and I think we'll be good to go! include/mesos/containerizer.proto <https://reviews.apache.org/r/20141/#comment73165> Sorry Till, I wasn't explicit enough about this refactor. Let's put this file in 'include/mesos/containerizer/containerizer.proto'. Then we can make the Java package match the C++ one, i.e., 'org.apache.mesos.containerizer'. Then the outer classname can be consistent with the others and just be 'Protos'. src/Makefile.am <https://reviews.apache.org/r/20141/#comment73166> Now this should be able to be just: JAVA_PROTOS = \ java/generated/org/apache/mesos/Protos.java \ java/generated/org/apache/mesos/containerizer/Protos.java And then below you should be able to define the Java targets like what was done for C++ and what you did for Python. src/Makefile.am <https://reviews.apache.org/r/20141/#comment73167> You'll want to update these with the new containerizer stuff too so that it gets installed. And feel free to create a 'containerizer.hpp' which wraps containerizer.pb.h just as we've done with 'mesos.hpp'. src/slave/containerizer/containerizer.hpp <https://reviews.apache.org/r/20141/#comment73191> As of now this isn't being installed and the convention is that we only use <> for things that get installed. Also, if you create a wrapper then you can use it here instead, i.e., 'mesos/containerizer/containerizer.hpp' (as we do with mesos/mesos.hpp). - Benjamin Hindman On April 11, 2014, 2:03 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20141/ > ----------------------------------------------------------- > > (Updated April 11, 2014, 2:03 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Adds containerizer.proto containing protobuf message definitions for > "Launch", "Update" and "Termination". All of those are used in the upcoming > External Containerizer. > These protos are defined within their own C++ namespace: "containerizer". > > Replaced slave::Containerizer::Termination with the > containerizer::Termination protobuf, gaining a serializable Termination > message. > > The protoc results are added towards the Python Egg (containerizer_pb2.py) > and the Java package (ContainerizerProtos.java). > > > Diffs > ----- > > include/mesos/containerizer.proto PRE-CREATION > src/Makefile.am 95f133d > src/slave/containerizer/containerizer.hpp d9ae326 > src/slave/containerizer/mesos_containerizer.hpp ee1fd30 > src/slave/containerizer/mesos_containerizer.cpp 1ce41d7 > src/slave/slave.hpp 08f6005 > src/slave/slave.cpp cddb241 > src/tests/containerizer.hpp a9f1531 > src/tests/containerizer.cpp bfb9341 > > Diff: https://reviews.apache.org/r/20141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
