----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19857/#review39953 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/19857/#comment72736> s/__recoverReregistrationTimeout/reregisterSlavesTimeout/ afaict, we haven't prefixed "__" for delayed methods in the code base (see authenticationTimeout, reregisterExecutorTimeout, shutdownExecutorTimeout). so lets stick to that style for consistency. src/master/master.hpp <https://reviews.apache.org/r/19857/#comment72729> s/reregistrationTimer/slaveReregsistrationTimer/ ? or pull this inside Slaves struct? src/master/master.hpp <https://reviews.apache.org/r/19857/#comment72732> s/re-register/re-register within the timeout/ ? src/master/master.cpp <https://reviews.apache.org/r/19857/#comment72734> How about making this configurable and have the current value as the default? Maybe another review and/or a TODO? - Vinod Kone On April 7, 2014, 7:03 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19857/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 7:03 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > This allows us to impose a limit on the number of slaves we will remove after > the timer expires. > > > Diffs > ----- > > src/master/master.hpp fef59c9971fcb3a5a33d7c94210b87edacb5719b > src/master/master.cpp 3c3c989543167afb7d368a19a16457ed00e6be0c > > Diff: https://reviews.apache.org/r/19857/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
