-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20309/#review40256
-----------------------------------------------------------
Bad patch!
Reviews applied: [20305, 20306, 20307, 20308, 20309]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
WARNING: '.' not a valid package name; please use only.-separated package names
in setup.py
package init file 'src/__init__.py' not found (or not a regular file)
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for
Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for
Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for
Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for
Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for
Ada/C/ObjC but not for C++ [enabled by default]
zip_safe flag not set; analyzing archive contents...
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
In file included from
../3rdparty/libprocess/3rdparty/gmock-1.6.0/include/gmock/internal/gmock-internal-utils.h:47:0,
from
../3rdparty/libprocess/3rdparty/gmock-1.6.0/include/gmock/gmock-actions.h:46,
from
../3rdparty/libprocess/3rdparty/gmock-1.6.0/include/gmock/gmock.h:58,
from tests/scheduler_tests.cpp:23:
../3rdparty/libprocess/3rdparty/gmock-1.6.0/gtest/include/gtest/gtest.h: In
function 'testing::AssertionResult testing::internal::CmpHelperNE(const char*,
const char*, const T1&, const T2&) [with T1 = unsigned int, T2 = int]':
tests/scheduler_tests.cpp:142:3: instantiated from here
../3rdparty/libprocess/3rdparty/gmock-1.6.0/gtest/include/gtest/gtest.h:1445:1:
error: comparison between signed and unsigned integer expressions
[-Werror=sign-compare]
cc1plus: all warnings being treated as errors
make[3]: *** [tests/mesos_tests-scheduler_tests.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [check-am] Error 2
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On April 14, 2014, 5:47 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20309/
> -----------------------------------------------------------
>
> (Updated April 14, 2014, 5:47 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Note that in an incremental review I plan to implement Scheduler
> and SchedulerDriver on this API so that we can run all existing tests using
> this API. For now I've included at least one test as a demonstration.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49
> include/mesos/scheduler.hpp 85db1117122441b5d9fb013380ea37aa0acc84ea
> src/Makefile.am 560b4c77a4e44ef1833b3b4afd95bb8040c9f229
> src/sasl/authenticatee.hpp 42a4eba2ae3eb4ea03826be38ee1f10121c60b4e
> src/sched/sched.cpp 3684cfe9d153cab5f4ea86094fffd814ce74baa1
> src/scheduler/scheduler.cpp PRE-CREATION
> src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4
> src/tests/scheduler_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20309/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
