----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20309/#review40279 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/20309/#comment73247> this might be cleaner if the messages aren't nested. As it is, it's tough to read and reason about. Or maybe it's just a matter of putting all the nested types first and then the fields? Did you consider the 'Nested Extensions' method: http://www.indelible.org/ink/protobuf-polymorphism/ ? include/mesos/scheduler.hpp <https://reviews.apache.org/r/20309/#comment73248> please use lambda::function here to avoid more c++11-only code paths. src/sched/sched.cpp <https://reviews.apache.org/r/20309/#comment73251> i know you're creating a copy here, but it reads like an explicit conversion call. Perhaps utils::copy would be clearer. src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73252> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73253> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73254> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73255> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73256> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73257> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73258> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73259> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73260> ws src/scheduler/scheduler.cpp <https://reviews.apache.org/r/20309/#comment73261> ws - Dominic Hamon On April 13, 2014, 10:47 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20309/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 10:47 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > See summary. Note that in an incremental review I plan to implement Scheduler > and SchedulerDriver on this API so that we can run all existing tests using > this API. For now I've included at least one test as a demonstration. > > > Diffs > ----- > > include/mesos/mesos.proto 37f8a7fcd23d467b1274c46c405b836510afbd49 > include/mesos/scheduler.hpp 85db1117122441b5d9fb013380ea37aa0acc84ea > src/Makefile.am 560b4c77a4e44ef1833b3b4afd95bb8040c9f229 > src/sasl/authenticatee.hpp 42a4eba2ae3eb4ea03826be38ee1f10121c60b4e > src/sched/sched.cpp 3684cfe9d153cab5f4ea86094fffd814ce74baa1 > src/scheduler/scheduler.cpp PRE-CREATION > src/tests/master_tests.cpp c047397654898b7b1715ee55c972b28c31f5b8c4 > src/tests/scheduler_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20309/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
