----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20297/#review40284 -----------------------------------------------------------
src/linux/routing/filter/ip.hpp <https://reviews.apache.org/r/20297/#comment73265> any reason why this isn't in its own header? src/linux/routing/filter/ip.hpp <https://reviews.apache.org/r/20297/#comment73268> these could be marked const and be public - Dominic Hamon On April 13, 2014, 4:50 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20297/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 4:50 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > The is Part 4 of the linux routing library. > > > Diffs > ----- > > src/Makefile.am 560b4c7 > src/linux/routing/filter/ip.hpp PRE-CREATION > src/linux/routing/filter/ip.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20297/diff/ > > > Testing > ------- > > make check > sudo make check > > > Thanks, > > Jie Yu > >
