-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review42800
-----------------------------------------------------------

Ship it!



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76716>

    s/has/have/



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76717>

    s/offset/offset of/ ?



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76718>

    s/destinationIP/destinationPorts/



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76719>

    why not offset and mask on the same line...?
    
    if (offset = 8 && mask = 0x00ff0000) {
    
    }



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76720>

    can you mention which part?



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76721>

    ditto.



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76722>

    ditto.



src/linux/routing/filter/ip.cpp
<https://reviews.apache.org/r/20297/#comment76724>

    include the value of size in the message.


- Vinod Kone


On April 28, 2014, 5:04 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20297/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 5:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod 
> Kone, and Cong Wang.
> 
> 
> Bugs: MESOS-1228
>     https://issues.apache.org/jira/browse/MESOS-1228
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The is Part 5 of the linux routing library.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d2e006d 
>   src/linux/routing/filter/ip.hpp PRE-CREATION 
>   src/linux/routing/filter/ip.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20297/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to