> On April 16, 2014, 12:46 a.m., Benjamin Hindman wrote: > > support/post-reviews.py, lines 101-103 > > <https://reviews.apache.org/r/20364/diff/1/?file=557924#file557924line101> > > > > I think this is fine, but what about also checking if you're on the > > master branch and giving a nice error message that says we're expecting you > > to be working on another branch from master? Thanks for making the tools > > easier to use Chengwei!
Yeah, that's great, I was thinking about adding such message, but I also thought "no new change compare with master branch!" also means you should not work on master branch, because if so, it always no new change from master. :-), OK, I'd like upload a new version with your comments, that's more straight forward. - Chengwei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20364/#review40401 ----------------------------------------------------------- On April 16, 2014, 1:18 a.m., Chengwei Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20364/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 1:18 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > post-reviews.py: handle working on master branch > > This is a small fix but wanted most by me, whenever working on master > branch directly with small patches, rather than a dedicate branch, > post-reviews.py doesn't handle this situation but just fail with the > trace back like: > > % ./support/post-reviews.py > Running post-review across all of ... > Traceback (most recent call last): > File "./support/post-reviews.py", line 104, in <module> > sha = line.split()[0] > IndexError: list index out of range > > This is not quite user friendly or make a lot of sense. This patch will > handle the above situation and notice user useful information. > > > Diffs > ----- > > support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d > > Diff: https://reviews.apache.org/r/20364/diff/ > > > Testing > ------- > > done. > > > Thanks, > > Chengwei Yang > >
