-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20364/
-----------------------------------------------------------

(Updated April 16, 2014, 10:01 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

make sure we're not working on master branch first.


Repository: mesos-git


Description (updated)
-------

post-reviews.py: handle working on master branch

This is a small fix but wanted most by me, whenever working on master
branch directly with small patches, rather than a dedicate branch,
post-reviews.py doesn't handle this situation but just fail with the
trace back like:

% ./support/post-reviews.py
Running post-review across all of ...
Traceback (most recent call last):
  File "./support/post-reviews.py", line 104, in <module>
    sha = line.split()[0]
IndexError: list index out of range

This is not quite user friendly or make a lot of sense. This patch will
handle the above situation and notice user useful information.

Review: https://reviews.apache.org/r/20364


Diffs (updated)
-----

  support/post-reviews.py 602e6600e65d2b122a2314694f6969a27b840c5d 

Diff: https://reviews.apache.org/r/20364/diff/


Testing (updated)
-------

done.

assuming working on master branch
% ./support/post-reviews.py
we're expecting you to be working on another branch from master!

assuming branch A is the same as master.
% ./support/post-reviews.py
Running post-review across all of ...
No new change compare with master branch!


Thanks,

Chengwei Yang

Reply via email to