----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20301/#review40487 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/20301/#comment73520> I think there are too many nested if else's here making it complicated to understand. Can you think of a better refactor that is easy to follow? src/master/master.cpp <https://reviews.apache.org/r/20301/#comment73514> We need to print this even when --credentials is not specified. src/sasl/common.hpp <https://reviews.apache.org/r/20301/#comment73517> put this under credentials namespace. src/sasl/common.hpp <https://reviews.apache.org/r/20301/#comment73519> with the name space change you can s/readCredentials/read/ - Vinod Kone On April 14, 2014, 5:01 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20301/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 5:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Moved reading of credentials file out of master.cpp and into sasl/common.hpp > for reuse by slave authentication. > > > Diffs > ----- > > src/master/master.cpp 3c3c989 > src/sasl/common.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20301/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
