> On April 17, 2014, 10:34 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 298 > > <https://reviews.apache.org/r/20301/diff/2/?file=561568#file561568line298> > > > > Log?
No longer doing validation here, just logging authentication state (changed comment to "Log authentication state." in case you like that better). With the addition of the --authenticate_slaves flag, we would need to EXIT(1) << "Authentication requires a credential file" if flags.credentials.isNone() and either authenticate flag is set. To simplify the code, this section now only logs the authentication state, and then we'll load credentials if flags.credentials.isSome(), else if either authenticate flag is set then we exit with the "requires credentials file" message. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20301/#review40665 ----------------------------------------------------------- On April 17, 2014, 1:56 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20301/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 1:56 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-804 > https://issues.apache.org/jira/browse/MESOS-804 > > > Repository: mesos-git > > > Description > ------- > > Refactored reading credentials file out of master.cpp and into > credentials/credentials.hpp for reuse by slave authentication. > > > Diffs > ----- > > src/credentials/credentials.hpp PRE-CREATION > src/master/master.cpp 0335b34 > > Diff: https://reviews.apache.org/r/20301/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Adam B > >
