----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20347/#review40594 -----------------------------------------------------------
Ship it! src/linux/routing/route.cpp <https://reviews.apache.org/r/20347/#comment73616> reorder alphabetically. src/linux/routing/route.cpp <https://reviews.apache.org/r/20347/#comment73617> put "o = nl_cach_get_next(o)" on the next line? src/linux/routing/route.cpp <https://reviews.apache.org/r/20347/#comment73618> pull this down to where it is used. src/linux/routing/route.cpp <https://reviews.apache.org/r/20347/#comment73619> can 'hop' be NULL? if so, what happens here? src/tests/routing_tests.cpp <https://reviews.apache.org/r/20347/#comment73620> you are checking for error instead of some because some hosts don't have a default gateway? - Vinod Kone On April 15, 2014, 6:10 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20347/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 6:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. I actually added the interface for getting the main routing > table. > > > Diffs > ----- > > src/Makefile.am 560b4c7 > src/linux/routing/route.hpp PRE-CREATION > src/linux/routing/route.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20347/diff/ > > > Testing > ------- > > make check > > also manually verify output against the output from netstat -rn > > > Thanks, > > Jie Yu > >
