> On April 16, 2014, 7:25 p.m., Vinod Kone wrote: > > src/linux/routing/route.cpp, line 97 > > <https://reviews.apache.org/r/20347/diff/3/?file=558277#file558277line97> > > > > can 'hop' be NULL? if so, what happens here?
Cannot. Added a CHECK_NOTNULL here. > On April 16, 2014, 7:25 p.m., Vinod Kone wrote: > > src/tests/routing_tests.cpp, line 112 > > <https://reviews.apache.org/r/20347/diff/3/?file=558278#file558278line112> > > > > you are checking for error instead of some because some hosts don't > > have a default gateway? Yes. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20347/#review40594 ----------------------------------------------------------- On April 15, 2014, 6:10 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20347/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 6:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod > Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. I actually added the interface for getting the main routing > table. > > > Diffs > ----- > > src/Makefile.am 560b4c7 > src/linux/routing/route.hpp PRE-CREATION > src/linux/routing/route.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/20347/diff/ > > > Testing > ------- > > make check > > also manually verify output against the output from netstat -rn > > > Thanks, > > Jie Yu > >
