----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20339/#review40703 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20339/#comment73811> Why do these two return Futures? That may make this difficult to use since any time you want to time something you need to use a continuation to proceed? We may also want to comment on what the 'key' signifies. I imagine that many use-cases do not need a key and hence would it be useful to have a default key of "" along with a note that the key is only for timing operations in a concurrent manner? - Ben Mahler On April 17, 2014, 4:10 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20339/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 4:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1217 > https://issues.apache.org/jira/browse/MESOS-1217 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491 > 3rdparty/libprocess/include/process/metrics/timer.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
