----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20339/#review40822 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20339/#comment73996> s/std::string()/""/ here and below? 3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20339/#comment73994> Can you add braces for the locked section and fix the indentation in this file? It will be a bit clunkier but, as you mentioned, we can add an RAII Lock (like the one in src/common/lock.hpp) later for our custom spinlock. The plan was to clean up our libprocess lock usage all at once. 3rdparty/libprocess/include/process/metrics/timer.hpp <https://reviews.apache.org/r/20339/#comment73995> s/Nanoseconds/Duration/ - Ben Mahler On April 17, 2014, 10:41 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20339/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 10:41 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1217 > https://issues.apache.org/jira/browse/MESOS-1217 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am d707ad759dacd16e0177e14f1bf5ece9e4ce2491 > 3rdparty/libprocess/include/process/metrics/timer.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
