> On April 17, 2014, 10:31 p.m., Ben Mahler wrote: > > src/master/flags.hpp, line 85 > > <https://reviews.apache.org/r/20374/diff/1/?file=558269#file558269line85> > > > > Failure to write will lead to a failover. Is 5 seconds enough for those > > placing their masters on shared disks? Maybe 10 seconds would be a better > > initial timeout since we're writing full snapshots?
How will this timeout interact with the timeout jie is introducing here: https://reviews.apache.org/r/18600/ Probably we will want the log recovery timeout to be smaller than this one. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20374/#review40706 ----------------------------------------------------------- On April 15, 2014, 5:56 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20374/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 5:56 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Getting this out for feedback then I'll likely add some tests (depending on > what bmahler is adding). > > > Diffs > ----- > > src/master/flags.hpp 024f86d93824a20ce42c28b8264576f1cb715d0e > src/master/registrar.cpp 9c0537d86036dec3e6a0fac84e167d9131242e0c > > Diff: https://reviews.apache.org/r/20374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
