> On April 17, 2014, 10:31 p.m., Ben Mahler wrote: > > Adding integration tests here is difficult because the Master will > > LOG(FATAL) when a failure occurs in the Registrar. > > > > However, we can add tests in registrar_tests.cpp to ensure that failures > > are returned by manipulating the clock and perhaps implementing a blocking > > Storage abstraction for the test?
Done! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20374/#review40706 ----------------------------------------------------------- On April 15, 2014, 5:56 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20374/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 5:56 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Getting this out for feedback then I'll likely add some tests (depending on > what bmahler is adding). > > > Diffs > ----- > > src/master/flags.hpp 024f86d93824a20ce42c28b8264576f1cb715d0e > src/master/registrar.cpp 9c0537d86036dec3e6a0fac84e167d9131242e0c > > Diff: https://reviews.apache.org/r/20374/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
