----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review40727 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/counter.hpp <https://reviews.apache.org/r/20015/#comment73867> Let's leave the existing style unchanged please! Functions on a single line are an exception. In duration.hpp, to take one example, we ended up adding one line functions because the bloat was significant and they can be grouped/formatted nicely. Here there seems to be a readability detraction, especially with reset() since the contents contain two function calls. 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73871> No need to self-reference: s/push i/I/ 3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20015/#comment73870> Can you fix the indentation here? Please take the time to look over your patches for things like this as it saves review time. :) - Ben Mahler On April 17, 2014, 11:16 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20015/ > ----------------------------------------------------------- > > (Updated April 17, 2014, 11:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/counter.hpp > f4774ada4dbe3fa18b5a8b204f97f59ca015b3c1 > 3rdparty/libprocess/include/process/metrics/gauge.hpp > 4f5c1086ac3553319431283165c5451df1a0ee3f > 3rdparty/libprocess/include/process/metrics/metric.hpp > ea64f699fd9ec38745d84c7523133709827f96db > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20015/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
