> On April 17, 2014, 3:09 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, line 32 > > <https://reviews.apache.org/r/20015/diff/8/?file=561399#file561399line32> > > > > Maybe a bit of documentation to describe what 'push' does? Would > > 'update' be clearer?
i chose 'push' as eventually there'll be a 'poll'. > On April 17, 2014, 3:09 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, lines 46-52 > > <https://reviews.apache.org/r/20015/diff/8/?file=561399#file561399line46> > > > > Why not stick the implementation of push() into Metric::push? I think > > our other 'Data' structs are pure structs, like Future::Data for example. i went back and forth on this. thanks for the guidance. > On April 17, 2014, 3:09 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/metric.hpp, lines 58-60 > > <https://reviews.apache.org/r/20015/diff/8/?file=561399#file561399line58> > > > > Would it be better to use an Option<Owned<...>> instead of relying on > > NULL? the comment explains why 'Option' doesn't work here. I can't get the option and then call 'set'. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20015/#review40701 ----------------------------------------------------------- On April 16, 2014, 3:51 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20015/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 3:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/counter.hpp > f4774ada4dbe3fa18b5a8b204f97f59ca015b3c1 > 3rdparty/libprocess/include/process/metrics/gauge.hpp > 4f5c1086ac3553319431283165c5451df1a0ee3f > 3rdparty/libprocess/include/process/metrics/metric.hpp > ea64f699fd9ec38745d84c7523133709827f96db > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb > > Diff: https://reviews.apache.org/r/20015/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Dominic Hamon > >
