----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20141/ -----------------------------------------------------------
(Updated April 18, 2014, 3:20 a.m.) Review request for mesos, Benjamin Hindman and Niklas Nielsen. Changes ------- - Moved containerizer.proto into mesos/include/containerizer - Reduced amount of required attributes within the Launch message - Added protobuf results wrapping containerizer.hpp as an installed header Repository: mesos-git Description ------- Adds containerizer.proto containing protobuf message definitions for "Launch", "Update" and "Termination". All of those are used in the upcoming External Containerizer. These protos are defined within their own C++ namespace: "containerizer". Replaced slave::Containerizer::Termination with the containerizer::Termination protobuf, gaining a serializable Termination message. The protoc results are added towards the Python Egg (containerizer_pb2.py) and the Java package (ContainerizerProtos.java). Diffs (updated) ----- include/mesos/containerizer/containerizer.hpp PRE-CREATION include/mesos/containerizer/containerizer.proto PRE-CREATION src/Makefile.am 560b4c7 src/slave/containerizer/containerizer.hpp d9ae326 src/slave/containerizer/mesos_containerizer.hpp ee1fd30 src/slave/containerizer/mesos_containerizer.cpp 1ce41d7 src/slave/slave.hpp 1e98795 src/slave/slave.cpp d6ec87c src/tests/containerizer.hpp a9f1531 src/tests/containerizer.cpp bfb9341 Diff: https://reviews.apache.org/r/20141/diff/ Testing ------- make check Thanks, Till Toenshoff