----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20018/#review40814 -----------------------------------------------------------
3rdparty/libprocess/include/process/metrics/metric.hpp <https://reviews.apache.org/r/20018/#comment73988> I missed this in the last review, can you use braces for the locked section? This was done in all other uses of internal::acquire/release as it makes it a bit easier to read! 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/20018/#comment73984> Can you describe why you want to do this? We can just make local http requests to get the JSON, right? 3rdparty/libprocess/src/metrics/metrics.cpp <https://reviews.apache.org/r/20018/#comment73983> Calling get() will crash if the option is none, are there some hidden semantics here that ensure these are SOME? - Ben Mahler On April 18, 2014, 7:38 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20018/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 7:38 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/metric.hpp > 6c48357a39598b5b0a324ed664366467c0518ebd > 3rdparty/libprocess/include/process/metrics/metrics.hpp > c20bb639e8ef79de63f0d0d56c2ea40a15a1f995 > 3rdparty/libprocess/src/metrics/metrics.cpp > 391295aea91e837bb856a40ef51d1c33d44371d8 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > abe1588c931b45a09294812974788aa74de44dd4 > > Diff: https://reviews.apache.org/r/20018/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > >
