-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20018/#review40859
-----------------------------------------------------------
Bad patch!
Reviews applied: [20047, 20018]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
In file included from
../../../3rdparty/libprocess/include/process/metrics/metrics.hpp:11:0,
from ../../../3rdparty/libprocess/src/metrics/metrics.cpp:12:
../../../3rdparty/libprocess/include/process/metrics/metric.hpp: In member
function 'Option<process::Statistics<double> >
process::metrics::Metric::statistics() const':
../../../3rdparty/libprocess/include/process/metrics/metric.hpp:35:59: error:
no matching function for call to
'process::Statistics<double>::Statistics(process::TimeSeries<double>&)'
../../../3rdparty/libprocess/include/process/metrics/metric.hpp:35:59: note:
candidates are:
../../../3rdparty/libprocess/include/process/statistics.hpp:72:12: note:
process::Statistics<T>::Statistics(const std::vector<typename
process::TimeSeries<T>::Value>&) [with T = double, typename
process::TimeSeries<T>::Value = process::TimeSeries<double>::Value]
../../../3rdparty/libprocess/include/process/statistics.hpp:72:12: note: no
known conversion for argument 1 from 'process::TimeSeries<double>' to 'const
std::vector<process::TimeSeries<double>::Value,
std::allocator<process::TimeSeries<double>::Value> >&'
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note:
constexpr process::Statistics<double>::Statistics(const
process::Statistics<double>&)
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: no
known conversion for argument 1 from 'process::TimeSeries<double>' to 'const
process::Statistics<double>&'
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note:
constexpr process::Statistics<double>::Statistics(process::Statistics<double>&&)
../../../3rdparty/libprocess/include/process/statistics.hpp:15:7: note: no
known conversion for argument 1 from 'process::TimeSeries<double>' to
'process::Statistics<double>&&'
../../../3rdparty/libprocess/src/metrics/metrics.cpp: In static member function
'static process::Future<process::http::Response>
process::metrics::internal::MetricsProcess::_snapshot(const
process::http::Request&, const hashmap<std::basic_string<char>,
process::Future<double> >&, const hashmap<std::basic_string<char>,
Option<process::Statistics<double> > >&)':
../../../3rdparty/libprocess/src/metrics/metrics.cpp:118:54: error: request for
member 'get' in '(& statistics)->process::Statistics<T>::min [with T =
double]()', which is of non-class type 'double'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:119:54: error: request for
member 'get' in '(& statistics)->process::Statistics<T>::max [with T =
double]()', which is of non-class type 'double'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:120:48: error: 'const
class process::Statistics<double>' has no member named 'median'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:121:48: error: 'const
class process::Statistics<double>' has no member named 'percentiles'
../../../3rdparty/libprocess/src/metrics/metrics.cpp:122:48: error: 'const
class process::Statistics<double>' has no member named 'percentiles'
make[5]: *** [libprocess_la-metrics.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On April 18, 2014, 10:48 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20018/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 10:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-1036
> https://issues.apache.org/jira/browse/MESOS-1036
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/metrics/metric.hpp
> 6c48357a39598b5b0a324ed664366467c0518ebd
> 3rdparty/libprocess/include/process/metrics/metrics.hpp
> c20bb639e8ef79de63f0d0d56c2ea40a15a1f995
> 3rdparty/libprocess/src/metrics/metrics.cpp
> 391295aea91e837bb856a40ef51d1c33d44371d8
> 3rdparty/libprocess/src/tests/metrics_tests.cpp
> abe1588c931b45a09294812974788aa74de44dd4
>
> Diff: https://reviews.apache.org/r/20018/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
