----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20580/#review41081 -----------------------------------------------------------
Can you also explain in the description what the bug was? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/20580/#comment74473> shouldn't this expectation be set before the slave is added? src/tests/allocator_tests.cpp <https://reviews.apache.org/r/20580/#comment74474> ditto. - Vinod Kone On April 22, 2014, 10:01 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20580/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:01 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-743 > https://issues.apache.org/jira/browse/MESOS-743 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 > > Diff: https://reviews.apache.org/r/20580/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --verbose > --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
