----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20580/#review41082 -----------------------------------------------------------
Ship it! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/20580/#comment74479> We try not to reuse the futures. So call this Future<Nothing> slaveAdded2 and the above one slaveAdded1; - Vinod Kone On April 22, 2014, 10:32 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20580/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:32 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-743 > https://issues.apache.org/jira/browse/MESOS-743 > > > Repository: mesos-git > > > Description > ------- > > In this test, expectation for slaveAdded being called for 'slave2' was set > but never waited on. So the test could run to completion without slave2 being > registered and added to allocator and thus fail the expectation. > > > Diffs > ----- > > src/tests/allocator_tests.cpp f6fa6c79088cf7676b088a4ef5bf8ae64f863435 > > Diff: https://reviews.apache.org/r/20580/diff/ > > > Testing > ------- > > ./bin/mesos-tests.sh --verbose > --gtest_filter=ReservationAllocatorTest.ResourcesReturned --gtest_repeat=200 > --gtest_break_on_failure > > > Thanks, > > Jiang Yan Xu > >
