> On April 23, 2014, 3:06 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 152 > > <https://reviews.apache.org/r/20581/diff/6/?file=566107#file566107line152> > > > > is 2 weeks about right for the state store timer history? or would a > > couple of days be more reasonable? > > Ben Mahler wrote: > Yeah it sounds good since the implicit maximum would be 1000 entries, > right? > > This means we're likely to start sparsifying significantly for a > long-running master, which is ok. > > Dominic Hamon wrote: > correct, the capacity will be 1000 entries so we may sparsify. I want to > make sure the inertia around aggregates isn't too large so we notice when/if > stores start taking longer. > > Ben Mahler wrote: > That's an excellent point! Longer term do we want to separate the notion > of time series history from aggregate history? I remember you mentioned > differentiating aggregates on standard window sizes, like 5min, 10min, 1hr, > ...? > > But for now, how about we make this smaller, say... 1 day?
that was when we had the idea that the time series window would be set on 'add' and kept in the MetricsProcess; it would allow the same Metric to have multiple histories. However, we still can consider separating the aggregate from the time series - especially if/when we get around to introducing the histogram abstraction. 1 day it is. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41228 ----------------------------------------------------------- On April 23, 2014, 1:48 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 1:48 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
