> On April 23, 2014, 12:52 p.m., Ben Mahler wrote: > > src/master/registrar.cpp, lines 384-385 > > <https://reviews.apache.org/r/20581/diff/5/?file=565979#file565979line384> > > > > Cool, it looks like the notion of timing a Future would have been > > useful for these cases as well!
yeah - when i started adding these i understood why that async op timer was important. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20581/#review41189 ----------------------------------------------------------- On April 23, 2014, 11:44 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20581/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 11:44 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added Timers for state store/fetch and a Gauge to track the length of the > operations queue. > > > Diffs > ----- > > src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 > > Diff: https://reviews.apache.org/r/20581/diff/ > > > Testing > ------- > > local build + mesos-local.sh + manual inspection. > make check. > > > Thanks, > > Dominic Hamon > >
