Updated the RB https://reviews.apache.org/r/20807/ adding file attachments that point to the patch that will be applied per file.
e.g. MESOS-1259-src-java-src-org-apache-mesos-state-ZooKeeperState.java MESOS-1259-src-java-src-org-apache-mesos-state-Variable.java I hope this makes the review a bit less painful. On Tue, Apr 29, 2014 at 11:55 AM, Benjamin Mahler <[email protected] > wrote: > Thanks for the javadoc pointer, your indentation changes SGTM! > > > On Mon, Apr 28, 2014 at 11:03 PM, Bernardo Gomez Palacio < > [email protected]> wrote: > >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/20807/ >> >> On April 29th, 2014, 1:03 a.m. UTC, *Ben Mahler* wrote: >> >> Thanks Bernardo, would you mind splitting up the diff so it's easier to >> review and commit incrementally? >> >> Took a quick glance: >> 1. What is the indentation being used on @param, how about just keeping it >> consistent with Scheduler.java's existing style? >> 2. Looks like there are some whitespace issues. >> >> I'll split it up per file. >> >> 1. The format, including indentation, is based on >> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html >> I have no problem changing the format btw. >> >> 2. Will fix them, sorry for the slippage. >> >> >> - Bernardo >> >> On April 28th, 2014, 10:22 p.m. UTC, Bernardo Gomez Palacio wrote: >> Review request for mesos and Mesos ReviewBot. >> By Bernardo Gomez Palacio. >> >> *Updated April 28, 2014, 10:22 p.m.* >> *Bugs: * MESOS-1259 <https://issues.apache.org/jira/browse/MESOS-1259> >> *Repository: * mesos-git >> Description >> >> [MESOS-1259]: Enrich the Java Docs in the src/java files. >> >> The Maven _package_ task will depends on the _javadoc:javadoc_ task. The >> _javadoc_ task fails if there are _Classes_ which expose _public_ fields >> or methods without proper _Java Documentation_. Note that by proper I am >> referring to the structure that is validated by the _Javadoc Tool_. >> >> In addition such documentation should facilitate the development of Java >> based frameworks. >> >> Testing >> >> 1. ./bootstrap && mkdir build && cd build && ../configure && make >> 2. The API Java Docs should be at build/src/java/target/apidocs >> 3. Open the index and navigate through the documentation. e.g. open >> build/src/java/target/apidocs/index.html >> >> . Please note that as of now the Protos.* are not available for the Javadocs >> therefore we are unable to link any reference. >> >> Diffs >> >> - src/java/src/org/apache/mesos/Executor.java (cacb4e9) >> - src/java/src/org/apache/mesos/ExecutorDriver.java (56345df) >> - src/java/src/org/apache/mesos/Log.java (d27e4f9) >> - src/java/src/org/apache/mesos/MesosExecutorDriver.java (ce146cd) >> - src/java/src/org/apache/mesos/MesosSchedulerDriver.java (3fd1eb5) >> - src/java/src/org/apache/mesos/Scheduler.java (3043f60) >> - src/java/src/org/apache/mesos/SchedulerDriver.java (ae2d915) >> - src/java/src/org/apache/mesos/state/State.java (d14d79b) >> - src/java/src/org/apache/mesos/state/ZooKeeperState.java (a21a4ae) >> >> View Diff <https://reviews.apache.org/r/20807/diff/> >> > >
