----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20807/#review42106 -----------------------------------------------------------
Patch looks great! Reviews applied: [20807] All tests passed. - Mesos ReviewBot On April 30, 2014, 11:01 p.m., Bernardo Gomez Palacio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20807/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 11:01 p.m.) > > > Review request for mesos and Mesos ReviewBot. > > > Bugs: MESOS-1259 > https://issues.apache.org/jira/browse/MESOS-1259 > > > Repository: mesos-git > > > Description > ------- > > [MESOS-1259]: Enrich the Java Docs in the src/java files. > > The Maven _package_ task will depends on the _javadoc:javadoc_ task. The > _javadoc_ task fails if there are _Classes_ which expose _public_ fields > or methods without proper _Java Documentation_. Note that by proper I am > referring to the structure that is validated by the _Javadoc Tool_. > > In addition such documentation should facilitate the development of Java > based frameworks. > > > Diffs > ----- > > src/java/src/org/apache/mesos/Executor.java cacb4e9 > src/java/src/org/apache/mesos/ExecutorDriver.java 56345df > src/java/src/org/apache/mesos/Log.java d27e4f9 > src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cd > src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb5 > src/java/src/org/apache/mesos/Scheduler.java 3043f60 > src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915 > src/java/src/org/apache/mesos/state/State.java d14d79b > src/java/src/org/apache/mesos/state/Variable.java 8e1ca69 > src/java/src/org/apache/mesos/state/ZooKeeperState.java a21a4ae > > Diff: https://reviews.apache.org/r/20807/diff/ > > > Testing > ------- > > 1. ./bootstrap && mkdir build && cd build && ../configure && make > 2. The API Java Docs should be at build/src/java/target/apidocs > 3. Open the index and navigate through the documentation. e.g. open > build/src/java/target/apidocs/index.html > > . Please note that as of now the Protos.* are not available for the Javadocs > therefore we are unable to link any reference. > > > File Attachments > ---------------- > > MESOS-1259-src-java-src-org-apache-mesos-state-ZooKeeperState.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/50071e59-be40-4b9b-924f-83c8814645b1__MESOS-1259-src-java-src-org-apache-mesos-state-ZooKeeperState.java > MESOS-1259-src-java-src-org-apache-mesos-state-Variable.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/2de4f9eb-5400-407b-b052-748e6694e1aa__MESOS-1259-src-java-src-org-apache-mesos-state-Variable.java > MESOS-1259-src-java-src-org-apache-mesos-state-State.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/12c78172-34f0-4842-a422-b83b10d5dc95__MESOS-1259-src-java-src-org-apache-mesos-state-State.java > MESOS-1259-src-java-src-org-apache-mesos-SchedulerDriver.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/445f44bc-e3a8-4d5d-bd26-67287530a989__MESOS-1259-src-java-src-org-apache-mesos-SchedulerDriver.java > MESOS-1259-src-java-src-org-apache-mesos-Scheduler.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/9b37a375-145b-464f-9c48-350f35c998b9__MESOS-1259-src-java-src-org-apache-mesos-Scheduler.java > MESOS-1259-src-java-src-org-apache-mesos-MesosSchedulerDriver.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/43416013-296d-4f31-9fe3-94e6a40c7f3d__MESOS-1259-src-java-src-org-apache-mesos-MesosSchedulerDriver.java > MESOS-1259-src-java-src-org-apache-mesos-Log.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/7df3d908-9d83-40d8-9747-12e92472d0f2__MESOS-1259-src-java-src-org-apache-mesos-Log.java > MESOS-1259-src-java-src-org-apache-mesos-ExecutorDriver.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/14e31044-3d03-4c2b-a72e-9fbd00a67e24__MESOS-1259-src-java-src-org-apache-mesos-ExecutorDriver.java > MESOS-1259-src-java-src-org-apache-mesos-Executor.java > > https://reviews.apache.org/media/uploaded/files/2014/04/30/4bfdd153-ef27-45f2-92b5-22443912cb0b__MESOS-1259-src-java-src-org-apache-mesos-Executor.java > > > Thanks, > > Bernardo Gomez Palacio > >
