----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20970/ -----------------------------------------------------------
(Updated May 2, 2014, 1:48 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Changes ------- Added additional comments. Improved test to verify zombie process exists. Repository: mesos-git Description ------- Uses kill(0, pid) to check pid validity. This is much cheaper than using os::process(pid) which constructs a full Process object. Works regardless of permission to signal the pid. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/stout/os/exists.hpp d9860d754e04f4ab5cc8f0a095b758ec62626b90 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 94eb256d24bc001660d63bd91b608988205a3d09 Diff: https://reviews.apache.org/r/20970/diff/ Testing ------- # Added a test make check Thanks, Ian Downes
