----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20970/#review42076 -----------------------------------------------------------
Ship it! Please go ahead and commit this, but first, please wrap comments at 70 characters. (I've seen a number of patches lately not doing this but this is actually part of our (unfortunately) implicit style). 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/20970/#comment75822> Consider having this loop fail after a certain amount of time has passed, akin to what is done in OsTest.killtree - Ben Mahler On May 2, 2014, 8:48 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20970/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 8:48 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Uses kill(0, pid) to check pid validity. This is much cheaper than using > os::process(pid) which constructs a full Process object. Works regardless of > permission to signal the pid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/exists.hpp > d9860d754e04f4ab5cc8f0a095b758ec62626b90 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 94eb256d24bc001660d63bd91b608988205a3d09 > > Diff: https://reviews.apache.org/r/20970/diff/ > > > Testing > ------- > > # Added a test > make check > > > Thanks, > > Ian Downes > >
